Skip to content

(Improvement) Remove CQL binary protocol v3 #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mykaul wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

(Improvement) Remove CQL binary protocol v3 #686

mykaul wants to merge 1 commit into from

Conversation

@mykaul
Copy link

@mykaul mykaul commented Feb 2, 2026

No one needs it anymore. Any reasonable version of Cassandra and ScyllaDB support CQL binary protocol v4 (or higher).

This also assume that we test against Cassandra 2.2 or above, so removed some <= 2.1 items.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@mykaul mykaul marked this pull request as draft February 2, 2026 21:56
@mykaul
(Improvement) Remove CQL binary protocol v3
3694533 
No one needs it anymore. Any reasonable version of Cassandra and ScyllaDB support
CQL binary protocol v4 (or higher).

This also assume that we test against Cassandra 2.2 or above, so removed some <= 2.1 items.

Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
@mykaul mykaul force-pushed the remove_proto_v3_clean branch from 59ebff4 to 3694533 Compare February 3, 2026 11:54
@mykaul
Copy link
Author

mykaul commented Feb 3, 2026

I'm very proud of:

+472 −1,193

@Lorak-mmk
Copy link

Lorak-mmk commented Feb 4, 2026

@mykaul Could you please discuss next steps for that with @roydahan ?
On last team call we raised the idea to remove protocol v3, first from matrix, then from driver and scylla.
Roy's concern is that it should be done with a proper depreciation announcements, making sure then no one uses it etc.

@mykaul
Copy link
Author

mykaul commented Feb 4, 2026

@mykaul Could you please discuss next steps for that with @roydahan ? On last team call we raised the idea to remove protocol v3, first from matrix, then from driver and scylla. Roy's concern is that it should be done with a proper depreciation announcements, making sure then no one uses it etc.

In theory, you are right. In practice - Scylla uses and supports v4, who is going to use v3 against it? and if they do, why would they upgrade their driver? but generally - fair point - we need to deprecate it in docs or something first. I'll get it to 2026.1 hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mykaul @Lorak-mmk